Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes#2569, changed fixed 4px to .38rem height. #2604

Closed
wants to merge 3 commits into from
Closed

closes#2569, changed fixed 4px to .38rem height. #2604

wants to merge 3 commits into from

Conversation

slzakaria
Copy link

The issue seems to be only in some browsers ( safari has it, firefox was fine) ,changed from fixed pixels to rem unit , displays the same accros the different browsers

The issue seems to be only in some browsers ( safari has it, firefox was fine) ,changed from fixed pixels to rem unit , displays the same accros the different browsers
closes#2569, changed fixed 4px to .38rem height.
@raimund-schluessler
Copy link
Contributor

This does not fix it in Chrome for me.
This does:

.progress-bar[value]::-webkit-progress-value {
    border-radius: 2px;
    height: 4px;
}

@raimund-schluessler
Copy link
Contributor

This does not fix it in Chrome for me. This does:

.progress-bar[value]::-webkit-progress-value {
    border-radius: 2px;
    height: 4px;
}

This means the CSS here needs to be adjusted depending on the prop:
https://github.com/nextcloud/nextcloud-vue/blob/593bc9d7f0be0b87eae2906844ea67b9d9c7b0ac/src/components/ProgressBar/ProgressBar.vue#L120-L126

@raimund-schluessler
Copy link
Contributor

@Zackaria-Slimane I had an idea how to fix this nicely with a lot less code and implemented it in #2618. I hope you don't mind that I close this one here in favor of #2618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants